Skip to content

Conversation

@mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR will attempt to remove the Windows Emscripten cross compile patch, in the same way it was removed from the Unix systems cross compile builds.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton force-pushed the Try-to-remove-cross-compile-patch-Windows branch 3 times, most recently from b009ec5 to 2f9a04b Compare July 23, 2025 17:51
@mcbarton mcbarton changed the title [wip] Remove Windows cross compile patch Remove Windows cross compile patch Jul 23, 2025
@mcbarton mcbarton requested a review from vgvassilev July 23, 2025 17:51
@mcbarton mcbarton marked this pull request as ready for review July 23, 2025 17:51
@mcbarton mcbarton force-pushed the Try-to-remove-cross-compile-patch-Windows branch from bdde19a to e104f5b Compare July 23, 2025 17:54
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.52%. Comparing base (82f08c6) to head (e104f5b).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files           9        9           
  Lines        3917     3917           
=======================================
  Hits         3115     3115           
  Misses        802      802           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jul 23, 2025

This PR is ready for review.

@vgvassilev vgvassilev requested a review from anutosh491 July 25, 2025 13:28
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great :)

@mcbarton mcbarton merged commit 3bc3b46 into compiler-research:main Jul 25, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Remove the need for Windows Emscripten llvm cross compilation patch

2 participants